-
Notifications
You must be signed in to change notification settings - Fork 8
Angular 17 ivy #1923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Angular 17 ivy #1923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kaskyi
approved these changes
Dec 8, 2023
ef91f5d
to
0ff41db
Compare
2bdfaa9
to
2341736
Compare
Signed-off-by: Yevhenii Kamenskyi <[email protected]> Ivy compatibility pass lint pass lint pass lint fix fix fix fix fix
e0d6aa0
to
56e8742
Compare
packages/components/table/collections/xm-table-array-collection-controller.ts
Show resolved
Hide resolved
sergeysenja1992
requested changes
Dec 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need look for workaround to avoid declare keyword in existing code
sergeysenja1992
approved these changes
Jan 3, 2024
fix(ace-editor): fix ace editor import
andrewkikot
approved these changes
Jan 8, 2024
Bozonych
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Сhange import from 'ng-jhipster' to '@xm-ngx/jhipster'
Сhange import from 'google-places-autocomplete' to '@xm-ngx/google-places-autocomplete'
Change import from 'ng-pick-datetime' to '@danielmoncada/angular-datetime-picker'
Change style imports
From @import '@angular/material/theming'; to @import '@angular/material'; or if you consider to use specific theme then you should use @use '@angular/material' as mat;
From @import 'ng-pick-datetime'; to @import '@danielmoncada/angular-datetime-picker/assets/style/picker.min';