Skip to content

Angular 17 ivy #1923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 8, 2024
Merged

Angular 17 ivy #1923

merged 13 commits into from
Jan 8, 2024

Conversation

zverbeta
Copy link
Contributor

@zverbeta zverbeta commented Dec 5, 2023

Сhange import from 'ng-jhipster' to '@xm-ngx/jhipster'
Сhange import from 'google-places-autocomplete' to '@xm-ngx/google-places-autocomplete'
Change import from 'ng-pick-datetime' to '@danielmoncada/angular-datetime-picker'

Change style imports
From @import '@angular/material/theming'; to @import '@angular/material'; or if you consider to use specific theme then you should use @use '@angular/material' as mat;
From @import 'ng-pick-datetime'; to @import '@danielmoncada/angular-datetime-picker/assets/style/picker.min';

@zverbeta zverbeta added ci-cd-trigger ci/cd trigger for test/build xw-webapp and removed ci-cd-trigger ci/cd trigger for test/build xw-webapp labels Dec 5, 2023
@zverbeta zverbeta added ci-cd-trigger ci/cd trigger for test/build xw-webapp and removed ci-cd-trigger ci/cd trigger for test/build xw-webapp labels Dec 6, 2023
@zverbeta zverbeta added ci-cd-trigger ci/cd trigger for test/build xw-webapp and removed ci-cd-trigger ci/cd trigger for test/build xw-webapp labels Dec 20, 2023
@zverbeta zverbeta added ci-cd-trigger ci/cd trigger for test/build xw-webapp and removed ci-cd-trigger ci/cd trigger for test/build xw-webapp labels Dec 26, 2023
Signed-off-by: Yevhenii Kamenskyi <[email protected]>

Ivy compatibility

pass lint

pass lint

pass lint

fix

fix

fix

fix

fix
Copy link
Member

@sergeysenja1992 sergeysenja1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need look for workaround to avoid declare keyword in existing code

@zverbeta zverbeta added ci-cd-trigger ci/cd trigger for test/build xw-webapp and removed ci-cd-trigger ci/cd trigger for test/build xw-webapp labels Jan 8, 2024
@zverbeta zverbeta merged commit 2f38efc into main Jan 8, 2024
@zverbeta zverbeta deleted the angular_17_ivy branch January 8, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd-trigger ci/cd trigger for test/build xw-webapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants