opt: continue to load dictionaries when some dictionaries throw exception. #2180
Conversation
| @@ -228,8 +232,6 @@ void loadDictionaries( QWidget * parent, | |||
| QMessageBox::critical( parent, | |||
| QCoreApplication::translate( "LoadDictionaries", "Error loading dictionaries" ), | |||
| QString::fromUtf8( loadDicts.getExceptionText().c_str() ) ); | |||
There was a problem hiding this comment.
Here should show all errors.
There was a problem hiding this comment.
do not want to change too much code. :-)
There was a problem hiding this comment.
Error handling should be religious, and silently ignoring errors is sinful 😅.
I think this only need to append the original exceptionText to a QStringList, then call QStringList::join('\n') here.
BTW, I think there should be a systematical way to report dict errors and warnings back to users.
There was a problem hiding this comment.
This can be left from another PR.
|
No description provided.