opt:refactor wordfinder,use signal/connect to handle single requestFinish event. #2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyifang
force-pushed
the
opt/word-finder
branch
from
6cc76c1 to
460e741
Compare
xiaoyifang
force-pushed
the
opt/word-finder
branch
2 times, most recently
from
7ea6fb8 to
30cfd40
Compare
xiaoyifang
force-pushed
the
staged
branch
2 times, most recently
from
c7d784f to
f2fe677
Compare
xiaoyifang
force-pushed
the
opt/word-finder
branch
3 times, most recently
from
e9fd4fe to
fc7f4a4
Compare
xiaoyifang
force-pushed
the
opt/word-finder
branch
3 times, most recently
from
c411c4d to
736be89
Compare
xiaoyifang
changed the title
use more specific signal to handle the event
xiaoyifang
force-pushed
the
opt/word-finder
branch
from
736be89 to
123d371
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relate #2113