Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fixes for note conversion path in repo migration. #396

Merged
merged 13 commits into from
Jun 25, 2024

Conversation

hoytak
Copy link

@hoytak hoytak commented Jun 19, 2024

Currently, the note conversion ran as a separate stage after the regular conversion, in which all blob oids in that stage reachable by notes and their dependents were considered note blobs. The exception to the building of this dependency tree is that attached commits that were already converted would be ignored.

The problem is that many blobs in this path may not actually be note blobs and should be put through the filter. The cases missed:

  • notes attached to blobs.
  • dependents of notes attached to trees. (notes have to be attached to a previously converted commit to turn off the switch saying it's a note).

This approach tracks whether an oid can be considered as a note through the different stages so blobs are filtered and not filtered properly.

@hoytak hoytak requested a review from seanses June 19, 2024 20:29
@hoytak hoytak merged commit febbf02 into main Jun 25, 2024
3 checks passed
@hoytak hoytak deleted the hoytak/240618-blob-tracking branch June 25, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants