More fixes for note conversion path in repo migration. #396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the note conversion ran as a separate stage after the regular conversion, in which all blob oids in that stage reachable by notes and their dependents were considered note blobs. The exception to the building of this dependency tree is that attached commits that were already converted would be ignored.
The problem is that many blobs in this path may not actually be note blobs and should be put through the filter. The cases missed:
This approach tracks whether an oid can be considered as a note through the different stages so blobs are filtered and not filtered properly.