Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cas protocol initiate root ca field #235

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Conversation

assafvayner
Copy link
Contributor

Adds root ca certificate field to CAS Initiate Response needed for upcoming Encryption in Transit work.

@@ -80,7 +80,7 @@ impl std::fmt::Display for common::Scheme {

impl std::fmt::Display for common::EndpointConfig {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
let common::EndpointConfig { host, port, scheme } = self;
let common::EndpointConfig { host, port, scheme, .. } = self;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work to make things open ended with the structs

Copy link

@hoytak hoytak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@assafvayner assafvayner merged commit 76f0835 into main Jan 10, 2024
3 checks passed
@assafvayner assafvayner deleted the assaf/cas-initiate-root-ca branch January 10, 2024 18:21
@port8080
Copy link
Contributor

🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants