-
Notifications
You must be signed in to change notification settings - Fork 243
feat: add support to x64 systems using musl #632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
fab9375
fix: add snappy support
samyuh 70e710c
fix: update alpine image
samyuh 0dc3e64
fix: update files
samyuh 38a20ff
fix: dockerfile building
samyuh 71b21bb
feat: adding alpine architecture
samyuh b8f2bea
feat: adding alpine architecture
samyuh 10001cb
feat: reset files
samyuh 23d729a
fix: remove code not used
samyuh 46a2b5c
docs: update build.md
samyuh a52520a
fix: dockerfile name
samyuh 4f963ca
feat: rename osname and image arch
samyuh 61ad7a7
feat: rename osname and image arch
samyuh 05b4000
feat: add try catch block
samyuh 8bd9b37
feat: better error message
samyuh 29f87f8
feat: address review comments
samyuh c3723e5
Update src/main/java/org/xerial/snappy/OSInfo.java
xerial 4e0df47
fix: use standard OSGi processor value for musl variant
xerial dc0cf13
fix: correct indentation in OSInfo.java catch block
xerial File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
FROM alpine:3.18 | ||
|
||
# Set workspace directory | ||
WORKDIR /work | ||
|
||
# Copy the project to the container | ||
COPY . . | ||
|
||
# Install build dependencies | ||
RUN apk add --no-cache \ | ||
openjdk8 \ | ||
cmake \ | ||
make \ | ||
gcc \ | ||
g++ \ | ||
musl-dev \ | ||
linux-headers \ | ||
git \ | ||
util-linux \ | ||
bash \ | ||
curl | ||
|
||
# Install SBT | ||
RUN curl -L "https://github.com/sbt/sbt/releases/download/v1.9.7/sbt-1.9.7.tgz" | tar xz -C /usr/local | ||
ENV PATH="/usr/local/sbt/bin:${PATH}" | ||
|
||
# Install python/pip | ||
ENV PYTHONUNBUFFERED=1 | ||
RUN apk add --update --no-cache python3 && ln -sf python3 /usr/bin/python | ||
RUN python3 -m ensurepip | ||
RUN pip3 install --no-cache --upgrade pip setuptools | ||
|
||
# Set Env Vars | ||
ENV CC=gcc CXX=g++ | ||
ENV JAVA_HOME=/usr/lib/jvm/java-1.8-openjdk | ||
ENV PATH="${JAVA_HOME}/bin:${PATH}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+274 KB
src/main/resources/org/xerial/snappy/native/Linux/x86_64-musl/libsnappyjava.so
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build configuration for
Linux-x86_64-musl
is very similar to the existingLinux-x86_64
configuration. This duplication can make future maintenance more difficult, as changes would need to be applied in two places. Consider refactoring the common settings into a reusable block to reduce redundancy.