Python3 deploy action mypy to review this pr.new#8
Python3 deploy action mypy to review this pr.new#8bernhardkaindl wants to merge 2 commits intomasterfrom
Conversation
Signed-off-by: Stephen Cheng <stephen.cheng@cloud.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1103,7 +1104,8 @@ def main(): | |||
| print_debug("sr_uuid_list = %s" % sr_uuid_list) | |||
|
|
|||
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "Dict[str, float]", variable has type "List[List[str]]") [assignment]
| @@ -1103,7 +1104,8 @@ def main(): | |||
| print_debug("sr_uuid_list = %s" % sr_uuid_list) | |||
|
|
|||
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Item "None" of "Optional[Match[str]]" has no attribute "group" [union-attr]
bernhardkaindl
force-pushed
the
python3-deploy-action-mypy-to-review-this-PR.new
branch
5 times, most recently
from
4191cbf to
9f1ac34
Compare
There was a problem hiding this comment.
📝 [mypy] reported by reviewdog 🐶
In function "rpc":
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "str", variable has type "List[str]") [assignment]
There was a problem hiding this comment.
📝 [mypy] reported by reviewdog 🐶
In member "init" of class "RRDUpdates":
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "str", target has type "int") [assignment]
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "str", target has type "int") [assignment]
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "str", target has type "int") [assignment]
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "str", target has type "int") [assignment]
There was a problem hiding this comment.
📝 [mypy] reported by reviewdog 🐶
In function "get_percent_mem_usage":
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
No overload variant of "getitem" of "list" matches argument type "str" [call-overload]
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
No overload variant of "getitem" of "list" matches argument type "str" [call-overload]
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
No overload variant of "getitem" of "list" matches argument type "str" [call-overload]
There was a problem hiding this comment.
📝 [mypy] reported by reviewdog 🐶
In member "__generate_alarm" of class "Variable":
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in string interpolation (expression has type "Optional[Any]", placeholder has type "Union[int, float, SupportsFloat]") [str-format]
There was a problem hiding this comment.
📝 [mypy] reported by reviewdog 🐶
In function "main":
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Statement is unreachable [unreachable]
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Non-overlapping equality check (left operand type: "bytes", right operand type: "Literal['refresh']") [comparison-overlap]
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Non-overlapping equality check (left operand type: "bytes", right operand type: "Literal['debug_mem']") [comparison-overlap]
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
If x = b'abc' then "%s" % x produces "b'abc'", not "abc". If this is desired behavior use "%r" % x. Otherwise, decode the bytes [str-bytes-safe]
Signed-off-by: Bernhard Kaindl <bernhardkaindl7@gmail.com>
bernhardkaindl
force-pushed
the
python3-deploy-action-mypy-to-review-this-PR.new
branch
2 times, most recently
from
1428571 to
9eea5c0
Compare
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "str", variable has type "list[str]") [assignment]
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Need type annotation for "objCount" (hint: "objCount: Dict[, ] = ...") [var-annotated]
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in string interpolation (expression has type "Any | None", placeholder has type "int | float | SupportsFloat") [str-format]
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Need type annotation for "all_xmlconfigs" (hint: "all_xmlconfigs: Dict[, ] = ...") [var-annotated]
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Need type annotation for "sruuids_by_hostuuid" (hint: "sruuids_by_hostuuid: Dict[, ] = ...") [var-annotated]
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Need type annotation for "all_otherconfigs" (hint: "all_otherconfigs: Dict[, ] = ...") [var-annotated]
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Need type annotation for "vm_mon_lookup" (hint: "vm_mon_lookup: Dict[, ] = ...") [var-annotated]
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Need type annotation for "sr_mon_lookup" (hint: "sr_mon_lookup: Dict[, ] = ...") [var-annotated]
| memfd.close() | ||
| memdict = [ m.split(':', 1) for m in memlist ] | ||
| memdict = dict([(k.strip(), float(re.search('\d+', v.strip()).group(0))) for (k,v) in memdict]) | ||
| memdict = dict([(k.strip(), float(re.search(r'\d+', v.strip()).group(0))) for (k,v) in memdict]) |
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "dict[str, float]", variable has type "list[list[str]]") [assignment]
| memfd.close() | ||
| memdict = [ m.split(':', 1) for m in memlist ] | ||
| memdict = dict([(k.strip(), float(re.search('\d+', v.strip()).group(0))) for (k,v) in memdict]) | ||
| memdict = dict([(k.strip(), float(re.search(r'\d+', v.strip()).group(0))) for (k,v) in memdict]) |
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Item "None" of "Match[str] | None" has no attribute "group" [union-attr]
bernhardkaindl
force-pushed
the
python3-deploy-action-mypy-to-review-this-PR.new
branch
from
9eea5c0 to
09fb886
Compare
2 participants
No description provided.