fix: handle case where google model lacks description #331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #325 .
The
chatgpt-shell-google--fetch-model-versions
fn loads model descriptions from Google via a GET to https://generativelanguage.googleapis.com/v1beta/modelsThe response is a set of records like the following.
In cases in which the model is deprecated, the
description
field has contained the word "deprecated". so the logic inchatgpt-shell-google--fetch-model-versions
filters out such records. In some cases, the data returned by Google does not include any description. EgThis change handles that case. With this change, the current Gemma model can be loaded.
I observed a separate problem using the Gemma model. It returns
This is a matter of API usage. See #334 .