Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NYS2AWS-172] fix broken Solr rollback mechanism for Solr 2.0.9.1 com… #116

Merged
merged 4 commits into from
Mar 11, 2025

Conversation

pvriel
Copy link
Contributor

@pvriel pvriel commented Mar 11, 2025

…munity

Basically, this is just a PR to get the bug fix of https://github.com/Alfresco/SearchServices/pull/435 in our codebase, since we are running a few Solr versions behind.

@pvriel pvriel self-assigned this Mar 11, 2025
@@ -79,6 +80,29 @@ subprojects {
smartCopy files(configurations.backup.files), "/opt/alfresco-search-services/solrhome/lib/"
smartCopy("${project.projectDir}/../local/93-restore-from-backup.sh", "/docker-entrypoint.d/")
smartCopy("${project.projectDir}/../local/solr.xml", "/opt/alfresco-search-services/solrhome/solr.xml")

if (project.solrSourceSetOverride != null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't you just put the relevant classes in webapp/WEB-INF/classes/.... ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thijslemmens I looked into this since this would have been a more clean approach, however, I couldn't find the classes dir. in the image. The only classes I can find are the onces I introduced myself. All other code seems to be packaged as JAR files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

root@50c520b84bee:/opt/alfresco-search-services/solr/server/solr-webapp/webapp/WEB-INF# ls
lib  web.xml  weblogic.xml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also ran some find commands on *classes* and *.class

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore my comments, this is actually possible.

@pvriel pvriel merged commit abddf28 into master Mar 11, 2025
7 checks passed
@pvriel pvriel deleted the NYS2AWS-172-fix-solr-rollback branch March 11, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants