Cleanup of BPF object build rules #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out we pass both -S and -c to clang, which has become an error starting from clang 20. The two-stage build using 'clang -S' followed by llc was used in the early days of BPF development, but these days, clang is perfectly happy to produce BPF object files directly. So use this opportunity to get rid of llc entirely, and simplify the BPF object build rules while we're add it, by moving all of the -W* defines to BPF_CFLAGS. Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
Add LLVM 20 and 6.13 kernels to the test matrix Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop using the two-stage clang/LLC build for BPF object files, and just let
clang produce the object files directly.
Fixes #491.