Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
0ec6a33
Update lycheeverse/lychee-action digest to 5c4ee84
xdev-renovate Aug 8, 2025
ca7d202
Update dependency org.assertj:assertj-core to v3.27.4
xdev-renovate Aug 8, 2025
e794a23
Update checkstyleVersion to v11
xdev-renovate Aug 8, 2025
6adb4a7
Update plugin org.jetbrains.intellij.platform to v2.7.1
xdev-renovate Aug 10, 2025
df23f84
Update actions/checkout action to v5
xdev-renovate Aug 12, 2025
57c975a
Update actions/checkout action to v5
xdev-renovate Aug 12, 2025
c7e35ec
Merge pull request #4 from xdev-software/renovate/lycheeverse-lychee-…
AB-xdev Aug 12, 2025
acf81d4
Merge pull request #5 from xdev-software/renovate/actions-checkout-5.x
AB-xdev Aug 12, 2025
d5670b4
Merge branch 'master' into update-from-template-merged
xdev-gh-bot Aug 12, 2025
9930dfe
Merge branch 'master' into update-from-template-merged
xdev-gh-bot Aug 12, 2025
9ca2403
Merge pull request #141 from xdev-software/renovate/major-checkstylev…
AB-xdev Aug 12, 2025
b329390
Merge pull request #140 from xdev-software/renovate/org.assertj-asser…
AB-xdev Aug 12, 2025
f2456db
Merge pull request #143 from xdev-software/renovate/actions-checkout-5.x
AB-xdev Aug 12, 2025
75356ec
Merge pull request #142 from xdev-software/renovate/org.jetbrains.int…
AB-xdev Aug 12, 2025
019ff58
Add configuration for Intellij PMD plugin
AB-xdev Aug 13, 2025
30fa81c
Merge remote-tracking branch 'origin/update-from-template'
AB-xdev Aug 13, 2025
29aa603
Enable async processing by default
AB-xdev Aug 13, 2025
5514b05
Merge branch 'master' into update-from-template-merged
xdev-gh-bot Aug 13, 2025
8d53531
Enhance default PMD ruleset
AB-xdev Aug 14, 2025
fa291d8
Merge branch 'master' into update-from-template-merged
xdev-gh-bot Aug 14, 2025
739ed7e
Update lycheeverse/lychee-action digest to 01a5c94
xdev-renovate Aug 23, 2025
28c4ef5
Merge pull request #6 from xdev-software/renovate/lycheeverse-lychee-…
AB-xdev Aug 25, 2025
db11f77
Merge branch 'master' into update-from-template-merged
xdev-gh-bot Aug 25, 2025
003d9ee
Merge branch 'master' into update-from-template-merged
xdev-gh-bot Aug 25, 2025
ebc6187
Update lycheeverse/lychee-action digest to 885c65f
xdev-renovate Aug 26, 2025
9b69998
Update plugin org.jetbrains.intellij.platform to v2.7.2
xdev-renovate Aug 26, 2025
9817342
Merge pull request #148 from xdev-software/renovate/org.jetbrains.int…
AB-xdev Aug 26, 2025
b2aeb89
Merge pull request #7 from xdev-software/renovate/lycheeverse-lychee-…
AB-xdev Aug 26, 2025
87adb6f
Merge branch 'master' into update-from-template-merged
xdev-gh-bot Aug 26, 2025
516bfe1
Merge branch 'master' into update-from-template-merged
xdev-gh-bot Aug 26, 2025
1011d9e
Update actions/setup-java action to v5
xdev-renovate Aug 26, 2025
e77b407
Merge pull request #149 from xdev-software/renovate/actions-setup-jav…
AB-xdev Aug 26, 2025
db5b2a4
Merge branch 'develop' into update-from-template-merged
xdev-gh-bot Aug 26, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions .config/pmd/java/ruleset.xml
Original file line number Diff line number Diff line change
Expand Up @@ -194,4 +194,52 @@
</rule>

<rule ref="category/java/security.xml"/>

<rule name="AvoidSystemSetterCall"
language="java"
message="Setters of java.lang.System should not be called unless really needed"
class="net.sourceforge.pmd.lang.rule.xpath.XPathRule">
<description>
Calling setters of java.lang.System usually indicates bad design and likely causes unexpected behavior.
For example, it may break when multiple Threads are setting the value.
It may also overwrite user defined options or properties.

Try to pass the value only to the place where it's really needed and use it there accordingly.
</description>
<priority>3</priority>
<properties>
<property name="xpath">
<value>
<![CDATA[
//MethodCall[starts-with(@MethodName,'set')]/TypeExpression[pmd-java:typeIsExactly('java.lang.System')]
]]>
</value>
</property>
</properties>
</rule>

<rule name="JavaObjectSerializationIsUnsafe"
language="java"
message="Using Java Object (De-)Serialization is unsafe and has led to too many security vulnerabilities"
class="net.sourceforge.pmd.lang.rule.xpath.XPathRule">
<description>
Nearly every known usage of (Java) Object Deserialization has resulted in [a security vulnerability](https://cloud.google.com/blog/topics/threat-intelligence/hunting-deserialization-exploits?hl=en).
Vulnerabilities are so common that there are [dedicated projects for exploit payload generation](https://github.com/frohoff/ysoserial).

Java Object Serialization may also fail to deserialize when the underlying classes are changed.

Use proven data interchange formats like JSON instead.
</description>
<priority>2</priority>
<properties>
<property name="xpath">
<value>
<![CDATA[
//ClassDeclaration[@Interface = false()]/ClassBody/FieldDeclaration/VariableDeclarator/VariableId[@Name='serialVersionUID'] |
//ConstructorCall/ClassType[pmd-java:typeIsExactly('java.io.ObjectInputStream') or pmd-java:typeIsExactly('java.io.ObjectOutputStream')]
]]>
</value>
</property>
</properties>
</rule>
</ruleset>
4 changes: 2 additions & 2 deletions .github/workflows/broken-links.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 15
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- run: mv .github/.lycheeignore .lycheeignore

- name: Link Checker
id: lychee
uses: lycheeverse/lychee-action@82202e5e9c2f4ef1a55a3d02563e1cb6041e5332 # v2
uses: lycheeverse/lychee-action@885c65f3dc543b57c898c8099f4e08c8afd178a2 # v2
with:
fail: false # Don't fail on broken links, create an issue instead

Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/check-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ jobs:
distribution: [temurin]

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Set up JDK
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
distribution: ${{ matrix.distribution }}
java-version: ${{ matrix.java }}
Expand Down Expand Up @@ -85,10 +85,10 @@ jobs:
distribution: [temurin]

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Set up JDK
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
distribution: ${{ matrix.distribution }}
java-version: ${{ matrix.java }}
Expand All @@ -108,10 +108,10 @@ jobs:
distribution: [temurin]

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Set up JDK
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
distribution: ${{ matrix.distribution }}
java-version: ${{ matrix.java }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/check-ide-compatibility.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ jobs:
"$AGENT_TOOLSDIRECTORY" || true
sudo df -h

- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Set up JDK
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
distribution: 'temurin'
java-version: 21
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Set up JDK
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
java-version: '21'
distribution: 'temurin'
Expand Down Expand Up @@ -50,7 +50,7 @@ jobs:
outputs:
upload_url: ${{ steps.create_release.outputs.upload_url }}
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Configure Git
run: |
Expand Down Expand Up @@ -103,10 +103,10 @@ jobs:
needs: [prepare_release]
timeout-minutes: 60
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Set up JDK
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
distribution: 'temurin'
java-version: 21
Expand Down Expand Up @@ -137,7 +137,7 @@ jobs:
needs: [publish]
timeout-minutes: 10
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Init Git and pull
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sync-labels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
with:
sparse-checkout: .github/labels.yml

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Set up JDK
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
distribution: 'temurin'
java-version: 21
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/update-from-template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
update_branch_merged_commit: ${{ steps.manage-branches.outputs.update_branch_merged_commit }}
create_update_branch_merged_pr: ${{ steps.manage-branches.outputs.create_update_branch_merged_pr }}
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
with:
# Required because otherwise there are always changes detected when executing diff/rev-list
fetch-depth: 0
Expand Down Expand Up @@ -183,7 +183,7 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
with:
# Required because otherwise there are always changes detected when executing diff/rev-list
fetch-depth: 0
Expand Down
4 changes: 1 addition & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@
out
classes

# Vim
*.swp

# Plugins
*.idea/checkstyle-idea.xml

Expand All @@ -29,6 +26,7 @@ build/
!.idea/saveactions_settings.xml
!.idea/checkstyle-idea.xml
!.idea/externalDependencies.xml
!.idea/PMDPlugin.xml

!.idea/inspectionProfiles/
.idea/inspectionProfiles/*
Expand Down
16 changes: 16 additions & 0 deletions .idea/PMDPlugin.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .idea/saveactions_settings.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ plugins {
id 'idea'
id 'checkstyle'
id 'pmd'
id 'org.jetbrains.intellij.platform' version '2.7.0'
id 'org.jetbrains.intellij.platform' version '2.7.2'
}

ext {
checkstyleVersion = '10.26.1'
checkstyleVersion = '11.0.0'

pmdVersion = '7.16.0'
}
Expand Down Expand Up @@ -61,7 +61,7 @@ dependencies {
testImplementation platform('org.junit:junit-bom:5.13.4'),
'org.junit.jupiter:junit-jupiter',
'org.junit.jupiter:junit-jupiter-engine',
'org.assertj:assertj-core:3.27.3'
'org.assertj:assertj-core:3.27.4'
testRuntimeOnly("org.junit.platform:junit-platform-launcher") {
because("Only needed to run tests in a version of IntelliJ IDEA that bundles older versions")
}
Expand Down