Skip to content

Commit eb5604b

Browse files
committed
CA-409628: remove duplicate exception backtrace
response_internal_error already calls Backtrace.is_important in the correct place, and logs the exception. There is no need to do that a 2nd time in the caller. Signed-off-by: Edwin Török <[email protected]>
1 parent 639a634 commit eb5604b

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

ocaml/libs/http-lib/http_svr.ml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -498,10 +498,8 @@ let read_request ?proxy_seen ~read_timeout ~total_timeout ~max_length fd =
498498
(Unix.error_message a) b c
499499
)
500500
| exc ->
501-
Backtrace.is_important exc ;
502501
response_internal_error exc fd
503-
~extra:(escape (Printexc.to_string exc)) ;
504-
log_backtrace exc
502+
~extra:(escape (Printexc.to_string exc))
505503
) ;
506504
(None, None)
507505

0 commit comments

Comments
 (0)