CA-409628: remove unnecessary log_backtrace from API boundary

We should only log_backtrace if we are the final handler.

The exception is raised here, so the caller will have a chance to log it.
This was also inconsistent: some *_interface logged the backtrace, and others didn't.

In theory there is a chance that the caller is buggy and doesn't log the correct backtrace.
But if we simplify the places that call the Backtrace module, we'll have fewer chances of that going wrong.

Signed-off-by: Edwin Török <[email protected]>

Author: edwintorok

ocaml/xapi-idl/gpumon/gpumon_interface.ml

@@ -88,7 +88,6 @@ let gpu_err =
     ; raiser=
         (fun e ->
           let exn = Gpumon_error e in
-          log_backtrace exn ;
           error "%s (%s)" (Printexc.to_string exn) __LOC__ ;
           raise exn
         )

ocaml/xapi-idl/memory/memory_interface.ml

@@ -88,7 +88,6 @@ let err =
     ; raiser=
         (fun e ->
           let exn = MemoryError e in
-          log_backtrace exn ;
           error "%s (%s)" (Printexc.to_string exn) __LOC__ ;
           raise exn
         )

ocaml/xapi-idl/network/network_interface.ml

@@ -295,7 +295,6 @@ let err =
     ; raiser=
         (fun e ->
           let exn = Network_error e in
-          log_backtrace exn ;
           error "%s (%s)" (Printexc.to_string exn) __LOC__ ;
           raise exn
         )

ocaml/xapi-idl/v6/v6_interface.ml

@@ -112,7 +112,6 @@ let err =
     ; raiser=
         (fun e ->
           let exn = V6_error e in
-          log_backtrace exn ;
           error "%s (%s)" (Printexc.to_string exn) __LOC__ ;
           raise exn
         )