This repository was archived by the owner on Jan 22, 2021. It is now read-only.
Adding b2c #44
Open
Adding b2c #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmontemagno
suggested changes
Jun 28, 2018
| @@ -15,10 +15,23 @@ public class CommonConstants | |||
| #endregion | |||
|
|
|||
| #region AD | |||
| public const bool USE_MSFT = false; | |||
There was a problem hiding this comment.
Can you set make a string to replace on the build server that this checks..
string string AppCenterUseMSFT = "AC_USEMSFT_NO";
public bool USE_MSFT = "AC_USEMSFT" == AppCenterUseMSFT;
and I will swap: AC_USEMSFT_NO with AC_USEMSFT
| @@ -46,11 +46,12 @@ | |||
| <key>CFBundleTypeRole</key> | |||
| <string>Editor</string> | |||
| <key>CFBundleURLName</key> | |||
| <string>com.microsoft.advocates</string> | |||
| <string>com.microsoft.cloudadvocates</string> | |||
There was a problem hiding this comment.
I would assume on the server we need to update the scripts to swap these out. Can you update the script in there.
|
Build scripts updated with the AC_USEMSFT environment variable. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.