Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom dynamic memory limit #2008

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Murmele
Copy link
Contributor

@Murmele Murmele commented Apr 4, 2025

Add possibility to easily overwrite the maxima dynamic memory limit in the gui

grafik

Currently the label is not vertically aligned. How can I achive this?

Murmele added 2 commits April 4, 2025 19:50
…n the gui

Reason/Description: Because I have to set it quite often, but I don't remember it.
Files: Configuration.cpp, Configuration.h, ConfigDialogue.cpp, and 2 more files
Files: ConfigDialogue.cpp
@daute
Copy link
Member

daute commented Apr 6, 2025

Hi,
thanks for the patch. This is only necessary/effective if the SBCL Lisp compiler is used. And it is not changed very often (I assume).
Would it be better to just add an example line (as -l lispname) in the gui? E.g.
-X '--dynamic-space-size nnn' Set the SBCL memory limit to nnn Megabytes?

As we have already described in the manual?
Best regards, Wolfgang

@Murmele
Copy link
Contributor Author

Murmele commented Apr 7, 2025

ne (as -l lispname) in the gui? E.g.

Good point, I will change it. Yes it will be set only once, but if you have multiple computers you have to set it everywhere and I have always to search where I find the command.

daute added a commit that referenced this pull request Apr 7, 2025
The check did not work, the hints for Maxima configuration were
not shown. Disable the check for now, it is clearly stated, that
these options only work for SBCL.

(See the discussion in: #2008)
@daute
Copy link
Member

daute commented Apr 7, 2025

That was already coded, but had a non working check for SBCL.
I disabled this check (for now), it is documented, that these options are only valid for SBCL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants