-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/v0.1 rc4 #26
Release/v0.1 rc4 #26
Conversation
The package directory is renamed from `GOES_DL` to `goesdl` to be compliant with the Python package naming convention.
…ect package name change to goesdl
…ect package name change to goesdl
…ge name change to goesdl
… no longer needed
Reviewer's Guide by SourceryThis pull request focuses on refactoring the project by renaming the root package from 'GOES_DL' to 'goesdl'. This change impacts the import statements, the package definition, and the test suite. Additionally, the documentation was updated to reflect the change, and a new example notebook was added. Class diagram showing updated import pathsclassDiagram
class goesdl {
+__version__: str
+__package_id__: str
+__package_name__: str
}
class dataset {
+GridSatProductLocatorB1
+GridSatProductLocatorGC
+GOESProductLocatorABIPP
}
class datasource {
+DatasourceAWS
+DatasourceHTTP
+DatasourceCache
}
class downloader {
+Downloader
+download_files()
+list_files()
+get_files()
}
goesdl --> dataset
goesdl --> datasource
goesdl --> downloader
note for goesdl "Package renamed from GOES_DL to goesdl"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Here's the code health analysis summary for commits Analysis Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @wvenialbo - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Rename the package from
GOES-DL
togoesdl
. Update the documentation and examples to reflect the new package name. Update the fourth-generation GOES satellites name from GOES 3rd Generation to GOES 4th Generation.Build:
CI:
Documentation:
Tests: