Repository navigation
Hot run: reload the running map on every save - #165
Conversation
After a hot run starts, each save of a Wurst file sends wurst.hotreload. Saves during a reload or another map command collapse into one more reload. A status bar item shows the hot run and stops it; wurst.hotReloadOnSave turns it off.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fcf64bd6be
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Hot run now reloads the running map on every save, like a dev server.
wurst.hotstartmapsucceeds, each save of a Wurst file sendswurst.hotreload.wurst.stopHotRun). An ordinary run, or a hot run that failed to start, leaves it off.wurst.hotReloadOnSave(default on) turns reloading on save off.executeMapCommandtakes an optional success callback, since a run answers null when it succeeds.On Lua projects this needs wurstscript/WurstScript#1543, which makes hot run build the Lua hot reload and
wurst.hotreloadreplace function bodies in the running game. On Jass it reloads through JHCR as the command already did.The server side was measured on the 3.0.1.24371 client, driven over the protocol as this extension drives it: hot run, then an edit saved (
didChange,didSave) andwurst.hotreload. The running map ran the edited bodies with its state kept.testHotRunReloadsOnSaveinscripts/test-language-features.jscovers the save handling.npx tsc --noEmit,npm run linton the touched files andnpm testpass (Windows). Not tried by clicking through VS Code itself.