Repository navigation
Fix list bounds and indexing/order lifecycle defects - #516
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes four defects found on master: LinkedList continues past bounds errors on Lua and can corrupt its sentinel; reentrant deindex hooks destroy the same UnitIndex twice; LastOrder conflicts with Unit's abortOrder and leaves units paused; order history retains one more entry than its documented limit.
Invalid list operations now stop safely, deindexing rejects same-unit recursion while preserving hook context, LastOrder re-exports the canonical helper (including for NoWurst consumers), and the history limit includes the newest order. Compatibility: the default retains three orders instead of the accidental four.
Validation:
Setup, compatibility and evidence are in tests/AUDIT_VALIDATION.md and tests/audit-native-results.json. Native runs used authenticated terminal results and matching source/map identities. No multiplayer input claim is made; no UI/local-player behavior changed.