Skip to content

Fix list bounds and indexing/order lifecycle defects - #516

Merged
Frotty merged 2 commits into
masterfrom
codex/stdlib-audit-lifetimes
Oct 22, 2026
Merged

Frotty merged 2 commits into
masterfrom
codex/stdlib-audit-lifetimes

Conversation

@Frotty

@Frotty Frotty commented Oct 22, 2026

Copy link
Copy Markdown
Member

Fixes four defects found on master: LinkedList continues past bounds errors on Lua and can corrupt its sentinel; reentrant deindex hooks destroy the same UnitIndex twice; LastOrder conflicts with Unit's abortOrder and leaves units paused; order history retains one more entry than its documented limit.

Invalid list operations now stop safely, deindexing rejects same-unit recursion while preserving hook context, LastOrder re-exports the canonical helper (including for NoWurst consumers), and the history limit includes the newest order. Compatibility: the default retains three orders instead of the accidental four.

Validation:

  • Typecheck passes; 752/752 interpreter tests pass, including ordinary/NoWurst consumer compilation and nested deindexing.
  • Six preparer tests and seven native-bridge self-tests pass.
  • Actual Warcraft III 3.0.1.24371, single client, 1x speed, background native harness: fixed Lua 69/69 and Jass 63/63; zero uncaught errors and eleven expected caught bounds errors on each.
  • Same native tests against each old production package: LinkedList fails nine assertions; UnitIndexer fails three plus reports the caught double-destruction error; LastOrder fails the history-limit and pause-state assertions. Original implicit-Wurst consumers also fail compilation with ambiguous abortOrder.
  • Native orders verify history and cancellation; a native timer verifies the aborted unit remains stopped. The suite explicitly checks that timer completed.

Setup, compatibility and evidence are in tests/AUDIT_VALIDATION.md and tests/audit-native-results.json. Native runs used authenticated terminal results and matching source/map identities. No multiplayer input claim is made; no UI/local-player behavior changed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T17:01:20.709303Z 6cc001b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Frotty
Frotty merged commit 84ca5c6 into master Oct 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant