Repository navigation
Support qualified static event registrations in Lua hot reload - #1589
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qualified static registrations such as
EventListener.add(EVENT_..., callback)andDamageEvent.addListener(102, callback)previously stayed outside the hot-reload registration model. Inserting distinct static handlers while editing an existing one could reject an ordinary edit; newly added handlers could remain unregistered. This appears in CF commits fc2ccf5 and 15d728e.The frontend now uses the resolved static target and stable operands for callback identity and owns each eligible top-level registration as the same complete init-action unit used for free calls. Existing handlers retain their captured state, new handlers run once, and native/named callbacks use the existing completion/retry/history contract. Static qualification changes keep the same target identity. Instance receivers, computed/local operands, generic qualifiers/callees and duplicate registrations retain their restrictions.
The action protocol advances to v2: even earlier action-aware sessions require restart, because they never recorded completion for qualified static calls. This avoids repeating already executed registrations after upgrading without changing the compiler version label.
Validation:
Hot reload remains experimental and opt-in. Live state/capture migration, undoing old effects and latest actual-Warcraft validation remain outstanding. This change does not claim complete application of arbitrary map commits. Linux is covered by PR CI; macOS and actual engine application are unverified. WurstScript2.1.0 release work is owned by its separate completed release task.