Repository navigation
Replay real map commits with hot reload correctness and work oracles - #1582
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8aa95a3a33
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b67d5bc75
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5be391eb58
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc59afcbed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The scalar artifact tests do not establish useful coverage or latency on real maps. Add an offline parent/child replay harness for committed map changes, with independent fresh-child Lua/manifest comparisons, actual backend work counters, phase timings and delivery/restart outcomes.
Export committed sources into a new isolated fixture, preserve original map checkouts, freeze and hash dependencies/assets, record explicit dependency overrides, and keep payload acceptance distinct from state warnings and test-only edits. Fail compilation/oracle mismatches visibly. Retry complete comparisons across getBuildDate minute boundaries without normalizing output or caching compile-time results.
Measured baseline: 24 child states match fresh builds. Castle Fight accepts 8/12 payloads (5/9 commits touching non-test source paths); Zombie Defense accepts 12/12 using an explicitly recorded newer Frentity fixture. Many accepted payloads warn about initialized state or existing closures. Median host publication/comparison is 7.01 s / 4.98 s. None uses the scalar backend, so these results claim no incremental backend speedup or release readiness. The documented next gate is ordinary symbol-referencing bodies plus fresh compile-time products.
Validation: complete 12-pair campaigns for both maps, exact Lua/full-manifest oracles, and smoke reruns of the final exporter/harness on both map fixtures. Windows x64 / Java 27; original dirty map checkouts untouched. No Warcraft client was launched. Ubuntu/macOS timings and gameplay application remain unverified. This PR changes profiling tools and documentation only.
Standalone Python regression validation exports the sole valid parent/child pair from a short Git history with no dependencies. It fails before the parentless-commit fix and passes on the final change.
Integration validation: merged current master with the org-owned generator pin, repeated both complete 12-pair frozen-map campaigns, and obtained exact Lua/manifest agreement and unchanged acceptance outcomes for all 24 states. Recorded generator-side ownership and revision prerequisites for broad body reuse.
Relative IO validation: the child JVM runs in the exported project. A child-JVM file probe fails outside that directory before the fix and successfully reads/writes the fixture-relative raw path after it. Both real-map smoke pairs also pass with the corrected working directory.