Repository navigation
Lua hot reload: a -build -luaHotReload takes the run arguments, not the build-only ones - #1559
Merged
Merged
Conversation
…he build-only ones
The command line added the build-only '+' lines of wurst_run.args to every -build. A new project's file has
+opt, +inline and +localOptimizations, which -luaHotReload refuses, so the documented command-line hot reload
failed on a default project ("-luaHotReload is for development builds: remove -inline and -opt."). A hot
reload build is a development build of the map a hot run starts, and takes the run arguments.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Mainadds the workspace'swurst_run.argsto the command line. Under-buildit also turns the build-only+lines into flags. A new project'swurst_run.argshas+opt,+inlineand+localOptimizations, and-luaHotReloadrefuses-inlineand-opt, so the command-line hot reload documented indocs/LUA_HOT_RELOAD.md(-build ... -luaHotReload, thenLuaHotReloadSession start/send) failed on a default project:grill run --hotandgrill reload(wurstscript/WurstSetup#87) build this way, so they failed on every default project too. The language server's hot run was not affected: a run takes only the shared-lines.Change
A
-buildwhose command line asks for-luaHotReloadtakes the run arguments ofwurst_run.args(the shared-lines) and not its build-only+lines. A release-buildis unchanged. The docs sentence on the command-line path says so.Validation
MainTests.hotReloadBuildTakesTheRunArgumentsNotTheBuildOnlyOnes: with a new project'swurst_run.args, a-build -luaHotReloadtakes-stacktracesand none of-opt,-inline,-localOptimizations; a plain-buildstill takes all of them. It failed before the change (-optwas taken).MainTestsandWurstCommandsTestspass locally (Windows).wurst_run.args, built with-build -lua -luaHotReload: the master jar fails with the error above; a jar of this branch builds and writes_build/luaHotReload/manifest.json.Not covered:
-luaHotReloadwritten intowurst_run.argsitself (rather than given on the command line) is still combined with the+lines of a release build and refused, with the message above.