#47 Streamline development process, fix phpstan. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkirsman
force-pushed
the
feature/#47-streamline-development-process
branch
from
35b0dbc to
b04066e
Compare
hkirsman
commented
Jun 28, 2023
| # phpstan extensions automatically, it starts do more scans with extensions like like mglaman/phpstan-drupal and | ||
| # phpstan/phpstan-deprecation-rules. | ||
| composer require 'wunderio/code-quality:2.3.0' --dev |
There was a problem hiding this comment.
Locking to 2.3.0 that does not install https://github.com/phpstan/extension-installer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This issue was initially tackled because of failing phpstan tests. We include latest Code Quality in this project and in latest 2.4.0 we include package that automatically loads all phpstan extensions (vs defining them manually in phpstan.neon). In ping project there are no extension loaded https://github.com/wunderio/drupal-ping/blob/master/.lando/cmd-scan#L13 , so quick fix for now is just use older version of Code Quality. Ragnar also created issue here mglaman/phpstan-drupal#580
The other part of the fixes are about confusing development setup (at least for me). In my mind it should be as easy as
lando start.Why clone drupal-project, name it drupal-ping, then clone the actual drupal-ping inside it etc. There's already install script that does most of the work, then why just not link the ping-php resources to the Drupal installation.Screenshots
Failing phpstan
Old readme:
Updated readme:
Testing notes
[email protected]:wunderio/drupal-ping.git && cd drupal-pinggit checkout feature/#47-streamline-development-processlando startlando scanlando test