Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#47 Streamline development process, fix phpstan. #48

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

hkirsman
Copy link
Collaborator

@hkirsman hkirsman commented Jun 28, 2023

Description

This issue was initially tackled because of failing phpstan tests. We include latest Code Quality in this project and in latest 2.4.0 we include package that automatically loads all phpstan extensions (vs defining them manually in phpstan.neon). In ping project there are no extension loaded https://github.com/wunderio/drupal-ping/blob/master/.lando/cmd-scan#L13 , so quick fix for now is just use older version of Code Quality. Ragnar also created issue here mglaman/phpstan-drupal#580

The other part of the fixes are about confusing development setup (at least for me). In my mind it should be as easy as lando start. Why clone drupal-project, name it drupal-ping, then clone the actual drupal-ping inside it etc. There's already install script that does most of the work, then why just not link the ping-php resources to the Drupal installation.

Screenshots

Failing phpstan
image

Old readme:
image

Updated readme:
image

Testing notes

  1. Clone this repo and cd into it

[email protected]:wunderio/drupal-ping.git && cd drupal-ping

  1. Change to this branch

git checkout feature/#47-streamline-development-process

  1. Start Lando

lando start

  1. Run scan

lando scan

  1. Run tests

lando test

@hkirsman hkirsman force-pushed the feature/#47-streamline-development-process branch from 35b0dbc to b04066e Compare June 28, 2023 08:29
# phpstan extensions automatically, it starts do more scans with extensions like like mglaman/phpstan-drupal and
# phpstan/phpstan-deprecation-rules.
composer require 'wunderio/code-quality:2.3.0' --dev
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locking to 2.3.0 that does not install https://github.com/phpstan/extension-installer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant