SLT-1193: Remove the deprecated mailhog service from Drupal and Front-end charts #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k4lv15
force-pushed
the
feature/SLT-1193-remove-mailhog
branch
from
3d36b94 to
adc74b5
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request removes the deprecated Mailhog service from the Helm charts and Drupal configurations in favor of using Mailpit. The key changes include, the complete removal of Mailhog template files and configurations, updates to value and schema files to exclude Mailhog settings, and the corresponding cleanup of conditional logic in Drupal templates and CI configuration.
Reviewed Changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| forked/codecentric/mailhog-5.1.0/* | Removed all Mailhog-related chart templates and configuration files |
| drupal/* | Removed Mailhog service configuration and references from Drupal files |
| .circleci/config.yml | Updated CI configuration to remove Mailhog-related repository addition |
Comments suppressed due to low confidence (2)
drupal/values.schema.json:634
- The 'mailhog' property is removed from the JSON schema. Please ensure that any associated documentation or migration guides are updated to reflect this breaking change.
"mailhog": {
drupal/templates/smtp-secret.yaml:1
- The removal of '.Values.mailhog.enabled' from the secret condition ensures that Mailhog secrets are no longer created. Please verify that this change aligns with the intended service deprecation strategy.
{{- if or .Values.mailpit.enabled .Values.smtp.enabled }}
|
Postponed until mailhog is properly deprecated in #484, marking as draft for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mailhog got deprecated in #478 and replaced by mailpit. This PR removes maillog from SIlta's helm charts completely.
Changes proposed:
IMPORTANT NOTE! This is a breaking change!
If you're overriding default mailhog configuration in your helm chart value override files (like silta/silta.yml etc)., make sure to switch to mailpit, otherwise helm chart installation will fail with schema validation errors. Also note that old mailhog URL is still working but redirected to /mailpit
I.e, if you had mailhog enabled:
Before: in silta/silta.yaml
After: in silta/silta.yaml