Skip to content

Make ionization and recombination components functions, optionally return level-resolved rates#444

Draft
wtbarnes wants to merge 7 commits into
mainfrom
density-dependent-rates
Draft

Make ionization and recombination components functions, optionally return level-resolved rates#444
wtbarnes wants to merge 7 commits into
mainfrom
density-dependent-rates

Conversation

@wtbarnes
Copy link
Copy Markdown
Owner

@wtbarnes wtbarnes commented May 5, 2026

Fixes #384
Fixes #385
Fixes #415
Fixes #416

Remaining TODOs

  • Return level-resolved ionization rates
  • Decide where to return the density-dependent advanced model rates
  • Add function for selecting a model atmosphere
  • Add methods for calculating CT ionization and recombination rates
  • Allow Element.ionization_equilibrium to accept a density and atmosphere model.

@wtbarnes wtbarnes force-pushed the density-dependent-rates branch from ee238fc to 50bc8a3 Compare May 7, 2026 22:07
@wtbarnes
Copy link
Copy Markdown
Owner Author

wtbarnes commented May 7, 2026

Some working notes for myself

  • Should have separate methods for charge transfer ionization/recombination
  • These can be added into total for ionization/recombination if model atmosphere is considered
  • Should ionization/recombination rate methods be able to return the advanced model rates?
  • These have the downside of needing to repeatedly calculate the level populations...
  • If not, then are they just all calculated in Element.ionization_equilibrium?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant