You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The WebBrokerApi inbound and outbound loops read from per-connection channels without checking whether the channels were closed. A closed channel receive returns a nil *connectors.Message, and the loops then dereference msg.Value, which can panic during connection teardown.
Goals
Make WebBrokerApi teardown safe when inbound or outbound channels are closed.
Add regression coverage for closed-channel loop exits.
Approach
Use the Go comma-ok channel receive pattern in both inboundLoop and outboundLoop.
Return immediately when the channel is closed or a nil message is received.
Add unit tests that close each channel and assert the loop returns without panicking.
User stories
N/A — bug fix for connection teardown robustness.
Documentation
N/A — internal panic guard only; no user-facing API or configuration change.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You have signed the CLA already but the status is still pending? Let us recheck it.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 05a57057-5a87-48bc-80f1-2170c10d7143
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
🔍 Trigger review
✨ Finishing Touches🧪 Generate unit tests (beta)
Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Resolves #1959.
The WebBrokerApi inbound and outbound loops read from per-connection channels without checking whether the channels were closed. A closed channel receive returns a nil
*connectors.Message, and the loops then dereferencemsg.Value, which can panic during connection teardown.Goals
Approach
inboundLoopandoutboundLoop.User stories
N/A — bug fix for connection teardown robustness.
Documentation
N/A — internal panic guard only; no user-facing API or configuration change.
Automation tests
go test ./internal/connectors/receiver/websocketgo test ./internal/connectors/receiver/...go test ./...fromevent-gateway/gateway-runtimeSecurity checks
Samples
N/A.
Related PRs
N/A.
Test environment
macOS Darwin 24.5.0 arm64; Go 1.26.2.