Skip OIDC session state removal for logout requests #2973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![wso2-engineering[bot]](https://avatars.githubusercontent.com/in/1856828?s=60&v=4){kind=small}
Comment on lines
65
to
+69
| if (StringUtils.equals(event.getEventName(), EventName.SESSION_TERMINATE.name())) { | ||
| Object context = event.getEventProperties().get(EventProperty.CONTEXT); | ||
| if (context != null) { | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
Log Improvement Suggestion No: 1
Suggested change
| if (StringUtils.equals(event.getEventName(), EventName.SESSION_TERMINATE.name())) { | |
| Object context = event.getEventProperties().get(EventProperty.CONTEXT); | |
| if (context != null) { | |
| return; | |
| } | |
| if (StringUtils.equals(event.getEventName(), EventName.SESSION_TERMINATE.name())) { | |
| Object context = event.getEventProperties().get(EventProperty.CONTEXT); | |
| if (context != null) { | |
| if (LOG.isDebugEnabled()) { | |
| LOG.debug("Skipping OIDC logout handling as context is present in session terminate event"); | |
| } | |
| return; | |
| } |
Contributor
There was a problem hiding this comment.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
| Comment | Accepted (Y/N) | Reason |
|---|---|---|
| #### Log Improvement Suggestion No: 1 |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #2973 +/- ##
============================================
- Coverage 58.38% 56.98% -1.41%
- Complexity 9100 9429 +329
============================================
Files 669 669
Lines 50309 53402 +3093
Branches 11397 12223 +826
============================================
+ Hits 29375 30431 +1056
- Misses 16880 18704 +1824
- Partials 4054 4267 +213
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
$Subject since it is handled in the OIDC logout endpoint