Improve claim retriving logic in JWTTokenGenerator #2969

piraveena · 2025-11-04T11:01:37Z

Proposed changes in this pull request

[List all changes you want to add here. If you fixed an issue, please
add a reference to that issue as well.]

When should this PR be merged

[Please describe any preconditions that need to be addressed before we
can merge this pull request.]

Follow up actions

[List any possible follow-up actions here; for instance, testing data
migrations, software that we need to install on staging and production
environments.]

Developer Checklist (Mandatory)

Complete the Developer Checklist in the related product-is issue to track any behavioral change or migration impact.

Checklist (for reviewing)

General

Is this PR explained thoroughly? All code changes must be accounted for in the PR description.
Is the PR labeled correctly?

Functionality

Are all requirements met? Compare implemented functionality with the requirements specification.
Does the UI work as expected? There should be no Javascript errors in the console; all resources should load. There should be no unexpected errors. Deliberately try to break the feature to find out if there are corner cases that are not handled.

Code

Do you fully understand the introduced changes to the code? If not ask for clarification, it might uncover ways to solve a problem in a more elegant and efficient way.
Does the PR introduce any inefficient database requests? Use the debug server to check for duplicate requests.
Are all necessary strings marked for translation? All strings that are exposed to users via the UI must be marked for translation.

Tests

Are there sufficient test cases? Ensure that all components are tested individually; models, forms, and serializers should be tested in isolation even if a test for a view covers these components.
If this is a bug fix, are tests for the issue in place? There must be a test case for the bug to ensure the issue won’t regress. Make sure that the tests break without the new code to fix the issue.
If this is a new feature or a significant change to an existing feature? has the manual testing spreadsheet been updated with instructions for manual testing?

Security

Confirm this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
Are all UI and API inputs run through forms or serializers?
Are all external inputs validated and sanitized appropriately?
Does all branching logic have a default case?
Does this solution handle outliers and edge cases gracefully?
Are all external communications secured and restricted to SSL?

Documentation

Are changes to the UI documented in the platform docs? If this PR introduces new platform site functionality or changes existing ones, the changes should be documented.
Are changes to the API documented in the API docs? If this PR introduces new API functionality or changes existing ones, the changes must be documented.
Are reusable components documented? If this PR introduces components that are relevant to other developers (for instance a mixin for a view or a generic form) they should be documented in the Wiki.

CLAassistant · 2025-11-04T11:01:44Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

WSO2 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

wso2-engineering · 2025-11-04T11:01:49Z

...ntity.oauth/src/main/java/org/wso2/carbon/identity/oauth2/authcontext/JWTTokenGenerator.java

            AuthenticatedUser authenticatedUser = new AuthenticatedUser();
            authenticatedUser.setUserName(UserCoreUtil.removeDomainFromName(tenantAwareUsername));
            authenticatedUser.setUserStoreDomain(IdentityUtil.extractDomainFromName(tenantAwareUsername));
            authenticatedUser.setTenantDomain(tenantDomain);


Log Improvement Suggestion No: 1

Suggested change

authenticatedUser.setTenantDomain(tenantDomain);

authenticatedUser.setTenantDomain(tenantDomain);

log.info("Generating JWT token for user: " + authenticatedUser.getUserName() + " in tenant: " + tenantDomain);

wso2-engineering · 2025-11-04T11:01:49Z

...ntity.oauth/src/main/java/org/wso2/carbon/identity/oauth2/authcontext/JWTTokenGenerator.java

+                missing.add(req);
+            }
+        }
+        if (!missing.isEmpty() && isExistingUser) {


Log Improvement Suggestion No: 2

Suggested change

if (!missing.isEmpty() && isExistingUser) {

if (!missing.isEmpty() && isExistingUser) {

log.debug("Fetching " + missing.size() + " missing claims from claims retriever for user: " + authzUser);

wso2-engineering

AI Agent Log Improvement Checklist

⚠️ Warning: AI-Generated Review Comments

The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.

✅ Before merging this pull request:

Review all AI-generated comments for accuracy and relevance.
Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.

Comment	Accepted (Y/N)	Reason
#### Log Improvement Suggestion No: 1
#### Log Improvement Suggestion No: 2

jenkins-is-staging · 2025-11-04T11:02:18Z

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/19066477424

codecov · 2025-11-04T11:13:54Z

Codecov Report

❌ Patch coverage is 0% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.04%. Comparing base (1a416de) to head (7703d76).

Files with missing lines	Patch %	Lines
...identity/oauth2/authcontext/JWTTokenGenerator.java	0.00%	36 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2969      +/-   ##
============================================
- Coverage     58.07%   58.04%   -0.04%     
+ Complexity     9628     9378     -250     
============================================
  Files           669      669              
  Lines         53605    53634      +29     
  Branches      12235    12244       +9     
============================================
  Hits          31131    31131              
- Misses        18118    18146      +28     
- Partials       4356     4357       +1

Flag	Coverage Δ
unit	`41.14% <0.00%> (-0.03%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jenkins-is-staging · 2025-11-04T11:55:01Z

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/19066477424
Status: success

jenkins-is-staging

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/19066477424

Improve claim retriving logic in JWTTokenGenerator

7703d76

wso2-engineering bot reviewed Nov 4, 2025

View reviewed changes

wso2-engineering bot suggested changes Nov 4, 2025

View reviewed changes

jenkins-is-staging approved these changes Nov 4, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Improve claim retriving logic in JWTTokenGenerator #2969

Improve claim retriving logic in JWTTokenGenerator #2969

Uh oh!

piraveena commented Nov 4, 2025

Uh oh!

CLAassistant commented Nov 4, 2025

Uh oh!

wso2-engineering bot Nov 4, 2025

Uh oh!

wso2-engineering bot Nov 4, 2025

Uh oh!

wso2-engineering bot left a comment

Uh oh!

jenkins-is-staging commented Nov 4, 2025

Uh oh!

codecov bot commented Nov 4, 2025

Uh oh!

jenkins-is-staging commented Nov 4, 2025

Uh oh!

jenkins-is-staging left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	if (!missing.isEmpty() && isExistingUser) {
	if (!missing.isEmpty() && isExistingUser) {
	log.debug("Fetching " + missing.size() + " missing claims from claims retriever for user: " + authzUser);

Improve claim retriving logic in JWTTokenGenerator #2969

Are you sure you want to change the base?

Improve claim retriving logic in JWTTokenGenerator #2969

Uh oh!

Conversation

piraveena commented Nov 4, 2025

Proposed changes in this pull request

When should this PR be merged

Follow up actions

Developer Checklist (Mandatory)

Checklist (for reviewing)

General

Functionality

Code

Tests

Security

Documentation

Uh oh!

CLAassistant commented Nov 4, 2025

Uh oh!

wso2-engineering bot Nov 4, 2025

Choose a reason for hiding this comment

Log Improvement Suggestion No: 1

Uh oh!

wso2-engineering bot Nov 4, 2025

Choose a reason for hiding this comment

Log Improvement Suggestion No: 2

Uh oh!

wso2-engineering bot left a comment

Choose a reason for hiding this comment

AI Agent Log Improvement Checklist

Uh oh!

jenkins-is-staging commented Nov 4, 2025

Uh oh!

codecov bot commented Nov 4, 2025

Codecov Report

Uh oh!

jenkins-is-staging commented Nov 4, 2025

Uh oh!

jenkins-is-staging left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants