fix(faustwp): include IV in token envelope HMAC (GHSA-q6pm-r77q-qcv3)#2386
Merged
Conversation
🦋 Changeset detectedLatest commit: 012678c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📦 Next.js Bundle Analysis for @faustwp/getting-started-exampleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Authenticates the full encoded token envelope by including the initialization vector in the HMAC input on both
encrypt()anddecrypt(). The on-the-wire layout (IV || HMAC || ciphertext) is unchanged; only the bytes fed intohash_hmac()change.Tracked in GHSA-q6pm-r77q-qcv3.
Changes
plugins/faustwp/includes/auth/functions.php— HMAC input changes from$cipher_textto$iv . $cipher_textinencrypt()anddecrypt().plugins/faustwp/tests/integration/AuthFunctionsTests.php— new coverage: round-trip across several plaintext sizes, rejection of modified ciphertext, rejection of modified IV, rejection of modified HMAC, rejection of truncated input..changeset/iv-hmac-token-envelope.md— patch-level changeset for@faustwp/wordpress-plugin.Compatibility
Tokens issued under the prior envelope rule will not decrypt on the patched version. Authorization codes (1 min) and access tokens (5 min) age out within their normal windows; refresh-token holders (2 weeks) are prompted to re-authenticate once.
Test plan
unit_test_plugingreen on the newAuthFunctionsTests.@faustwp/wordpress-pluginto 1.8.8.