Skip to content

Fix newly reported PHPStan errors#77

Open
swissspidy wants to merge 2 commits intomainfrom
fix-phpstan
Open

Fix newly reported PHPStan errors#77
swissspidy wants to merge 2 commits intomainfrom
fix-phpstan

Conversation

@swissspidy
Copy link
Member

No description provided.

@swissspidy swissspidy requested a review from a team as a code owner February 12, 2026 13:28
Copilot AI review requested due to automatic review settings February 12, 2026 13:28
@gemini-code-assist
Copy link

Summary of Changes

Hello @swissspidy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses newly reported PHPStan errors by updating a core dependency and suppressing a specific type-related warning. The changes ensure compatibility with the latest wp-cli version and maintain a clean static analysis report, improving code quality and preventing potential issues.

Highlights

  • Dependency Update: The wp-cli/wp-cli dependency in composer.json has been updated from version ^2.12 to ^2.13.
  • PHPStan Error Suppression: A @phpstan-ignore varTag.type annotation was added in src/Rewrite_Command.php to address a newly reported PHPStan error related to variable type tags.
Changelog
  • composer.json
    • Updated wp-cli/wp-cli dependency to ^2.13.
  • src/Rewrite_Command.php
    • Added a PHPStan ignore tag for a varTag.type error.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Here are some useful Composer commands to get you started:

  • composer install: Install dependencies.
  • composer test: Run the full test suite.
  • composer phpcs: Check for code style violations.
  • composer phpcbf: Automatically fix code style violations.
  • composer phpunit: Run unit tests.
  • composer behat: Run behavior-driven tests.

To run a single Behat test, you can use the following command:

# Run all tests in a single file
composer behat features/some-feature.feature

# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123

You can find a list of all available Behat steps in our handbook.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix newly reported PHPStan errors by updating the wp-cli/wp-cli dependency and suppressing a varTag.type error with a @phpstan-ignore annotation. While this works, a better approach is to address the underlying type mismatch. My review suggests replacing the object shape in the @var tag with the specific class \WP_CLI\ProcessRun that WP_CLI::runcommand() returns. This not only resolves the PHPStan error correctly but also improves code clarity and maintainability.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses newly reported PHPStan findings in the rewrite command package by adjusting static analysis handling and updating the WP-CLI dependency version.

Changes:

  • Suppresses a PHPStan varTag.type error for the $process_run variable in Rewrite_Command::structure().
  • Bumps the required wp-cli/wp-cli version from ^2.12 to ^2.13.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/Rewrite_Command.php Adds a PHPStan suppression for a variable PHPDoc type mismatch around WP_CLI::runcommand().
composer.json Updates the minimum required WP-CLI version to ^2.13.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@swissspidy swissspidy added this to the 2.0.17 milestone Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant