-
Notifications
You must be signed in to change notification settings - Fork 24
Allow filtering languages by multiple statuses #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution! This looks great already. Question: can we also add this for |
Do you want the update in this PR or could this be split into separate tickets? |
|
I think it's easier if it's all in the same ticket & PR. It shouldn't require big changes, but let me know if you need help |
Ok, I will update this PR asap. This is my first contribution but I think I should be fine, otherwise, I will ask in the cli channel. |
|
@swissspidy I've updated the PR to add support to the other commands + added tests. I don't like the copy/pasted logic, but I don't want to refactor this on my first-ever contribution 😂 |
swissspidy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Makes it possible to filter using multiple statuses.
Example:
wp language core list --status=active,installedImplementation is based on this comment and code example
Fixes #96