-
Notifications
You must be signed in to change notification settings - Fork 63
PHPStan level 9 #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
PHPStan level 9 #286
Conversation
if ( false === $modes ) { | ||
$modes = []; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was never false
foreach ( [] as $arg ) { | ||
if ( isset( $assoc_args[ $arg ] ) ) { | ||
$args[ $arg ] = $assoc_args[ $arg ]; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looping through an empty array does nothing
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Depends on: