Draft
Conversation
szepeviktor
reviewed
Apr 26, 2024
Comment on lines
+1154
to
1156
| || 'beta' === $assoc_args['version'] | ||
| || 'rc' === $assoc_args['version'] | ||
| || 'nightly' === $assoc_args['version'] |
Contributor
There was a problem hiding this comment.
Why not use in_array here?
Contributor
Author
There was a problem hiding this comment.
Yep could do. I try to touch as few lines as possible, at least to begin with.
Member
|
It would be nice (although not urgent) if we could pick this up again. I think if For that we need to update the Then we can use that class here |
Contributor
Author
|
If someone wants to take this over be my guest. See #17 for some more recent discussion and linked meta issues. |
github-actions
bot
added
command:core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17.