Adapt block type tests to work across all WP versions#10
Conversation
Summary of ChangesHello @schlessera, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the existing block type command tests to enhance their reliability and compatibility across different WordPress versions. The primary change involves switching the specific block types used in test assertions from Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the block type feature tests to improve their reliability across different WordPress versions. The main change is replacing assertions for the core/paragraph static block with the core/archives dynamic block, which is more consistently registered. The tests have also been refactored to better organize checks for dynamic and static blocks, with tests for static blocks now correctly scoped to WordPress 5.5 and later. I've suggested re-introducing a test to verify is_dynamic:false for a static block within the appropriate scenario to maintain test coverage.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Fixes #7