Skip to content

Adapt block type tests to work across all WP versions#10

Merged
schlessera merged 2 commits intomainfrom
fix/block-type-tests-for-old-wps
Dec 11, 2025
Merged

Adapt block type tests to work across all WP versions#10
schlessera merged 2 commits intomainfrom
fix/block-type-tests-for-old-wps

Conversation

@schlessera
Copy link
Member

Fixes #7

@schlessera schlessera requested a review from a team December 11, 2025 16:38
@schlessera schlessera added the scope:testing Related to testing label Dec 11, 2025
@schlessera schlessera added this to the 1.0.0 milestone Dec 11, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @schlessera, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the existing block type command tests to enhance their reliability and compatibility across different WordPress versions. The primary change involves switching the specific block types used in test assertions from core/paragraph and core/heading to core/archives and core/categories. This modification addresses potential inconsistencies in block availability or behavior, particularly concerning dynamic block properties, ensuring the tests remain accurate and stable regardless of the WordPress environment.

Highlights

  • Test Block Type Update: Replaced core/paragraph with core/archives and core/heading with core/categories in various wp block type command tests to ensure more consistent behavior across WordPress versions.
  • Cross-Version Compatibility: The changes aim to make block type tests more robust and compatible across various WordPress versions by utilizing blocks with more stable and predictable properties for testing.
  • Dynamic/Static Block Testing Refinement: Adjusted tests to better reflect dynamic vs. static block properties, including adding new checks for the --format=count output and clarifying static block registration behavior in WordPress 5.5 and later.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the block type feature tests to improve their reliability across different WordPress versions. The main change is replacing assertions for the core/paragraph static block with the core/archives dynamic block, which is more consistently registered. The tests have also been refactored to better organize checks for dynamic and static blocks, with tests for static blocks now correctly scoped to WordPress 5.5 and later. I've suggested re-introducing a test to verify is_dynamic:false for a static block within the appropriate scenario to maintain test coverage.

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@schlessera schlessera merged commit caede57 into main Dec 11, 2025
99 of 121 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing tests on older WP versions (< 5.5)

2 participants