-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Queue with Fixed implementation #1
Conversation
Generally looks good, sorry about the invariant hiccup this morning. Queues use errors to signal when they are full/empty, but it is perfectly fine to retry later. Producers/consumers work differently, they block (or suspend) until they can produce/consume more data. Queues don't have that mechanism. |
For the fuzz tests, could you make sure that they catch simple errors in the fixed capacity implementation (say, deliberately introducing off-by-one errors). I can't see the progress, so for all I know, the fuzz tests passed at first go (because they are faulty and I am just not seeing it). |
Good idea. I introduced off-by-one errors in several places successively and each of them failed as expected. |
Queue
traitFixed
implementation ofQueue