Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling for downloads #106

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

russss
Copy link

@russss russss commented Jan 9, 2025

Pull Request Template

Description

This adds better handling for data file downloads, and raises an error if an HTML response is detected rather than producing zero-size h5 files.

With my Earthdata account I had to visit one of the data file URLs and grant permissions before I could download the data. This change now makes this much more obvious, as it outputs the failing URL which you can visit in a browser and see what the issue is.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Screenshots (if appropriate)

Additional context

russss added 2 commits January 9, 2025 14:18
This adds better handling for data file downloads, and raises an error
if an HTML response is detected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant