feat: PHPStan Request Factories - Upgrade to PHPStan 2.x #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odinns
force-pushed
the
JIRA-14001-update-php-stan-request-factories-package-to-php-stan-2-0
branch
3 times, most recently
from
87bfaaa to
5ad4032
Compare
odinns
changed the title
owenvoke
reviewed
Dec 4, 2024
odinns
force-pushed
the
JIRA-14001-update-php-stan-request-factories-package-to-php-stan-2-0
branch
3 times, most recently
from
36d5f73 to
7f413bf
Compare
owenvoke
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Fine with me. 👍🏻 Happy for this to be merged now, or can wait until Rector 2.x is released for worksome/coding-style#80
I will wait until Rector 2.x is released so I don't have to make a new PR to change the coding-style dependency. We can reference this branch now when testing upgrading platform to PHPStan 2 😊 |
odinns
changed the title
odinns
changed the title
Upgraded to PHPStan 2.x for a 2.0 release.
owenvoke
force-pushed
the
JIRA-14001-update-php-stan-request-factories-package-to-php-stan-2-0
branch
from
7f413bf to
d461422
Compare
owenvoke
approved these changes
Dec 12, 2024
|
Just pushed to update to Coding Style 3.x, so this is ready to go. 👍🏻 |
odinns
deleted the
JIRA-14001-update-php-stan-request-factories-package-to-php-stan-2-0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded to PHPStan 2.x for a 2.0 release.