fix: fall back from nonfinite Retry-After values - #742
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
Contributor
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A malformed Retry-After header such as
NaN,Infinity, or an overflowing numeric value currently reaches time.sleep/asyncio.sleep. This can replace the API error with a ValueError/OverflowError or leave an asynchronous retry waiting indefinitely.Treat nonfinite numeric values as invalid headers and use the existing exponential backoff, just as for other unparseable Retry-After values. Valid numeric values and HTTP dates retain their behavior.
Six sync/async response regressions fail before the fix and pass afterward. The complete suite passes: 2,887 tests. Ruff and git diff --check pass.
Documentation
No public API or documentation changes required.