fix: clear before cursor when advancing pagination - #741
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
Contributor
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When auto-pagination starts from a
beforecursor, subsequent requests currently contain both the originalbeforeand the newaftercursor. Removebeforefrom the copied parameters when advancing, for both sync and async clients. The first request and the caller's original parameters remain unchanged, and other query filters are preserved.The change is limited to the hand-maintained base client and pagination tests. Both new HTTP regression tests fail before the fix. All 2,883 tests pass afterward; Ruff and git diff --check pass.
Documentation
No documentation changes required; this restores forward auto-pagination using the existing API.