Skip to content

fix: clear before cursor when advancing pagination - #741

Open
Shubham-Padkonde wants to merge 1 commit into
workos:mainfrom
Shubham-Padkonde:fix/pagination-before-cursor
Open

Shubham-Padkonde wants to merge 1 commit into
workos:mainfrom
Shubham-Padkonde:fix/pagination-before-cursor

Conversation

@Shubham-Padkonde

Copy link
Copy Markdown

Description

When auto-pagination starts from a before cursor, subsequent requests currently contain both the original before and the new after cursor. Remove before from the copied parameters when advancing, for both sync and async clients. The first request and the caller's original parameters remain unchanged, and other query filters are preserved.

The change is limited to the hand-maintained base client and pagination tests. Both new HTTP regression tests fail before the fix. All 2,883 tests pass afterward; Ruff and git diff --check pass.

Documentation

No documentation changes required; this restores forward auto-pagination using the existing API.

@Shubham-Padkonde
Shubham-Padkonde requested review from a team as code owners October 2, 2026 05:33
@greptile-apps

greptile-apps Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Fixes pagination cursor handling when moving forward.

The PR appears safe to merge.

Summary

The PR removes the initial before cursor from subsequent forward-pagination requests in both clients while retaining other filters and leaving caller parameters unchanged. New HTTP tests verify the request parameters for sync and async pagination.

Reviews (1) · Last reviewed commit: "fix: clear before cursor when advancing ..."

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant