Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.0.0 #239

Merged
merged 2 commits into from
Mar 21, 2024
Merged

v4.0.0 #239

merged 2 commits into from
Mar 21, 2024

Conversation

mthadley
Copy link
Contributor

@mthadley mthadley commented Mar 21, 2024

Description

Includes...

Making this a major version bump since one of the commits drop support for Python 2.

Documentation

Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.

[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

@mthadley mthadley requested a review from a team as a code owner March 21, 2024 17:44
@mthadley mthadley requested a review from amygdalama March 21, 2024 17:44
Copy link

linear bot commented Mar 21, 2024

Copy link
Contributor

@ameesha ameesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amygdalama
Copy link
Contributor

we'll need to add session.created today too, should we wait for that? 🤔

or we could do two releases.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.04%. Comparing base (150d8ae) to head (5ad19fe).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #239   +/-   ##
=======================================
  Coverage   86.04%   86.04%           
=======================================
  Files          31       31           
  Lines        1247     1247           
=======================================
  Hits         1073     1073           
  Misses        174      174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mthadley
Copy link
Contributor Author

we'll need to add session.created today too, should we wait for that? 🤔

or we could do two releases.

@amygdalama Do we need to make changes in this SDK to support the new event?

Maybe I'm missing it, but I didn't recall any enum equivalent in Python for event types.

@amygdalama
Copy link
Contributor

oh! ok nice nvm then

@mthadley mthadley changed the title v3.2.0 v4.0.0 Mar 21, 2024
@mthadley mthadley requested a review from ameesha March 21, 2024 19:16
@mthadley
Copy link
Contributor Author

FYI: Making this a major version bump since one of the commits drops support for Python 2.

Copy link
Contributor

@ameesha ameesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@jonatascastro12 jonatascastro12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for covering the Python 2 here @mthadley

@mthadley mthadley merged commit bdf68dd into main Mar 21, 2024
10 checks passed
@mthadley mthadley deleted the feature/auth-2884-update-python-sdk--release branch March 21, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants