-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4.0.0 #239
v4.0.0 #239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll need to add session.created today too, should we wait for that? 🤔 or we could do two releases. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
=======================================
Coverage 86.04% 86.04%
=======================================
Files 31 31
Lines 1247 1247
=======================================
Hits 1073 1073
Misses 174 174 ☔ View full report in Codecov by Sentry. |
@amygdalama Do we need to make changes in this SDK to support the new event? Maybe I'm missing it, but I didn't recall any enum equivalent in Python for event types. |
oh! ok nice nvm then |
FYI: Making this a major version bump since one of the commits drops support for Python 2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for covering the Python 2 here @mthadley
Description
Includes...
WorkOSAuthenticationResponse
#237Making this a major version bump since one of the commits drop support for Python 2.
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.