-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sample apps for Python SDK v5 #59
Changes from 1 commit
152b941
320abf0
480d240
e0e094d
c92e84b
358d7ab
a78fcfc
e4c08eb
6b32200
25f6754
2f0a918
7994681
1328d22
a93126f
635152e
ceb7141
7979026
3d99705
680846c
2c4ec79
1c1f24b
a648ffe
2c793de
fbe32ce
738f955
29d6a8b
ee10c0d
143e051
4bb9401
70fb316
cdd2936
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
certifi==2021.5.30 | ||
charset-normalizer==2.0.6 | ||
click==8.0.1 | ||
Flask==2.0.1 | ||
Flask==2.0.3 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Different examples used different flask versions. I set them all to the same version. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any reason we can't bump to the latest Flask version? Also fine with keeping this out of scope. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The only reason I didn't bump up to latest version was to limit the scope of changes as I swept through and updated the sample apps. Basically, time savings for me in case bumping up to latest Flask triggered other code or dependency changes. |
||
idna==3.2 | ||
itsdangerous==2.0.1 | ||
Jinja2==3.0.1 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels kind of odd to me for a public example. I wonder if we should just use the
WORKOS_BASE_URL
environment variable here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. This is a simple change I can make to all of the sample apps.