fix: avoid calling headers() in middleware context #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the headers() call conditional in getAuthorizationUrl() to prevent "headers was called outside request scope" error when running Next.js standalone output with Bun. The headers() function from next/headers is designed for Server Components and Route Handlers, not middleware. When called from middleware context (via updateSession), redirectUri is already passed in, so we can skip the headers() call entirely. Fixes #288
mthadley
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
headers()call conditional ingetAuthorizationUrl()- only called whenredirectUriisn't already providedThe
headers()function fromnext/headersis designed for Server Components and Route Handlers, not middleware. WhengetAuthorizationUrl()is called from middleware context (viaupdateSession),redirectUriis already passed in, so we can skip theheaders()call entirely.Fixes #288