Add WFO Object and Array field #1980
Conversation
🦋 Changeset detectedLatest commit: 9e3d82b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
DutchBen
force-pushed
the
wfo-array-object-field
branch
from
ea8fb82 to
75e1b77
Compare
Georgi2704
force-pushed
the
wfo-array-object-field
branch
from
75e1b77 to
8b4b6cc
Compare
| }); | ||
|
|
||
| const minusButton = css({ | ||
| width: '40px', |
There was a problem hiding this comment.
For this and other magic values in this PR:
Is there already some kind of theming file in this project?
There was a problem hiding this comment.
I can make them use the defaultOrchestratorTheme values as close as possibe. I made them like this to be consistent with the old uniforms.
There was a problem hiding this comment.
Align them with the theme. No need to align with the uniforms I would say
packages/orchestrator-ui-components/src/components/WfoPydanticForm/WfoPydanticForm.tsx
Show resolved
Hide resolved
| return field.type === PydanticFormFieldType.OBJECT; | ||
| }, | ||
| }, | ||
| { |
There was a problem hiding this comment.
In the defaultComponentMatcher in the pydantic-forms lib there are some other fields that match on field type array like the MultiSelectField. This matcher should be after defaut matchers or else they will hijack matches that should end up there
There was a problem hiding this comment.
This is now the default object field matcher.
...estrator-ui-components/src/components/WfoPydanticForm/fields/WfoArrayField/WfoArrayField.tsx
Show resolved
Hide resolved
| ); | ||
|
|
||
| const renderField = (field: Record<'id', string>, index: number) => { | ||
| //TODO: Temporary fix for wrapper showing in arrayItem when not necessary |
There was a problem hiding this comment.
Is there a ticket for this? I am running into the same thing
No description provided.