Skip to content

Fix test test_retry_authorization #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 21, 2025
Merged

Fix test test_retry_authorization #979

merged 6 commits into from
Jul 21, 2025

Conversation

tjeerddie
Copy link
Contributor

@tjeerddie tjeerddie commented Jun 27, 2025

the test raises:

ValueError: Failed to write failure step to process: process with PID f4e1a612-e1f0-4432-b109-16de73637dcd not found

because tests have a scoped DB session that doesn't actually commits to the DB, so when the test was resumed with a intentional exception, it also rolls back the created process, resulting in the process not being found after rollback and trying to save the step as failed.

I fixed it by creating a test for each specific case, not running the wf twice (WIP)

fixes: #939 (comment)
Related: #898

Copy link

codspeed-hq bot commented Jun 27, 2025

CodSpeed Performance Report

Merging #979 will not alter performance

Comparing 898-fix-auth-test (c74c7dc) with main (a8f3468)

Summary

✅ 12 untouched benchmarks

@tjeerddie tjeerddie force-pushed the 898-fix-auth-test branch from f6a2f57 to 342539d Compare June 30, 2025 10:41
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.40%. Comparing base (a8f3468) to head (c74c7dc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #979      +/-   ##
==========================================
+ Coverage   84.39%   84.40%   +0.01%     
==========================================
  Files         213      213              
  Lines       10359    10359              
  Branches     1019     1019              
==========================================
+ Hits         8742     8744       +2     
+ Misses       1348     1345       -3     
- Partials      269      270       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tjeerddie tjeerddie force-pushed the 898-fix-auth-test branch from 8dcee5f to a42a3ce Compare July 3, 2025 12:11
Copy link
Member

@pboers1988 pboers1988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pboers1988 pboers1988 merged commit 3ab3628 into main Jul 21, 2025
13 checks passed
@pboers1988 pboers1988 deleted the 898-fix-auth-test branch July 21, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants