-
Notifications
You must be signed in to change notification settings - Fork 20
Fix test test_retry_authorization #979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #979 will not alter performanceComparing Summary
|
f6a2f57
to
342539d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #979 +/- ##
==========================================
+ Coverage 84.39% 84.40% +0.01%
==========================================
Files 213 213
Lines 10359 10359
Branches 1019 1019
==========================================
+ Hits 8742 8744 +2
+ Misses 1348 1345 -3
- Partials 269 270 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8dcee5f
to
a42a3ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
the test raises:
because tests have a scoped DB session that doesn't actually commits to the DB, so when the test was resumed with a intentional exception, it also rolls back the created process, resulting in the process not being found after rollback and trying to save the step as failed.
I fixed it by creating a test for each specific case, not running the wf twice (WIP)
fixes: #939 (comment)
Related: #898