[WIP] Remove vite-inline-css plugin #271
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #269
If we can find another way to tamp down the logspam, I might be open to keeping it, but @bluskript I'd need you to please elaborate on the advantages. We have SCSS going already, and it seems to serve a lot of the same purposes. (and
@applyseems to confuse SCSS, so I'm not sure I want to write a "different type" of CSS in the JS than in our preprocessed stuff)Generally, I'm thinking I want to remove it and keep doing things the old fashioned way cause it's simpler to understand. Appreciate the effort to try something new though.
I think this PR still doesn't look exactly right so it's a WIP. @bluskript what am I missing?
e.g., this PR:
main: