Skip to content

Added logo upload feature #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

ValdoTR
Copy link
Contributor

@ValdoTR ValdoTR commented Oct 27, 2021

/!\ WIP /!\

Adds the logo upload feature, which is basically another field type in the config panel that deals with the preview and the replacement of the old logo URL defined in a Tiled variable by a new one, uploaded by the user.

I called this 'logo' replacement but this could be really any image in Tiled.
You can test this with the map: 'configuration_logo.json'

TODO:

  • Add a real upload API endpoint
  • Work a little bit on the CSS
  • Resize the actual file (not just its rendering)
  • Refactore the whole code to use the Store instead of only the script part of Field.svlete

PS: This is working with a local upload (uploading locally the image in the disk and retrieving the path, then replacing the image)

image

@codecov-commenter
Copy link

Codecov Report

Merging #81 (32cfec4) into main (5bb55b0) will not change coverage.
The diff coverage is n/a.

❗ Current head 32cfec4 differs from pull request most recent head 3f6c8e3. Consider uploading reports for the commit 3f6c8e3 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage   55.17%   55.17%           
=======================================
  Files           1        1           
  Lines          29       29           
  Branches        5        5           
=======================================
  Hits           16       16           
  Misses         13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bb55b0...3f6c8e3. Read the comment docs.

@ValdoTR ValdoTR changed the title Adds logo upload feature Added logo upload feature Jan 31, 2022
@gparant gparant force-pushed the main branch 9 times, most recently from d04a7e4 to 1ff439b Compare October 4, 2022 14:15
@gparant gparant force-pushed the main branch 2 times, most recently from f66b844 to 54d554c Compare April 29, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants