Skip to content

Grid view in the new media screen#25561

Merged
crazytonyli merged 6 commits into
trunkfrom
task/media-v2-grid
Jun 10, 2026
Merged

Grid view in the new media screen#25561
crazytonyli merged 6 commits into
trunkfrom
task/media-v2-grid

Conversation

@crazytonyli

@crazytonyli crazytonyli commented May 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Similar to the existing Media screen, the grid view is 4 columns in compact width and 5 in regular, supports the same aspect-ratio / square toggle as V1 (sharing the UserDefaults key, so the preference carries over between the two screens), and renders per-kind cells for image, video, audio, and document.

Analytics for filter, search, and the grid toggle are routed through MediaTrackerAdapter to Tracks under new WPAnalyticsStat cases that mirror V1's event names.

Aspect Ratio Mode Grid Mode
Simulator.Screen.Recording.-.iPhone.17.-.2026-06-05.at.21.40.49.mov

@dangermattic

dangermattic commented May 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator
2 Warnings
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved.

If the change includes adding, removing, or editing a dependency please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).

If the change to the Package.swift did not modify dependencies, ignoring this warning should be safe, but we recommend double checking and running the package resolution just in case.
.
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@crazytonyli crazytonyli force-pushed the task/media-v2-grid branch from c106304 to 512afad Compare May 14, 2026 06:33
@wpmobilebot

wpmobilebot commented May 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🤖 Build Failure Analysis

This build has failures. Claude has analyzed them - check the build annotations for details.

@crazytonyli crazytonyli force-pushed the task/media-v2-grid branch 2 times, most recently from 883a054 to 18ef295 Compare May 17, 2026 22:43
@wpmobilebot

wpmobilebot commented May 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number32436
VersionPR #25561
Bundle IDorg.wordpress.alpha
Commitcbfa85e
Installation URL3umel5p784a4o
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot

wpmobilebot commented May 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number32436
VersionPR #25561
Bundle IDcom.jetpack.alpha
Commitcbfa85e
Installation URL1ldhl1kh4euoo
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Base automatically changed from task/media-v2-foundation to trunk June 4, 2026 21:24
@crazytonyli crazytonyli force-pushed the task/media-v2-grid branch from 18ef295 to cbfa85e Compare June 5, 2026 09:32
@crazytonyli crazytonyli requested a review from jkmassel June 5, 2026 09:44
@crazytonyli crazytonyli added this to the 27.0 milestone Jun 5, 2026
@crazytonyli crazytonyli marked this pull request as ready for review June 5, 2026 09:44
@crazytonyli crazytonyli mentioned this pull request Jun 8, 2026
Open
jkmassel
jkmassel reviewed Jun 10, 2026
View reviewed changes
Comment thread Modules/Sources/WordPressMediaLibrary/Models/MediaGridDuration.swift
/// stable `digit:digit` output is the better fit. This is a small,
/// deliberate deviation from V1's `SiteMediaCollectionCellViewModel.swift`'s
/// `makeString(forDuration:)`.
enum MediaGridDuration {

@jkmassel jkmassel Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use Swift's Duration.TimeFormatStyle.Pattern to accomplish this?

Then it can be locale-aware, but still fixed-size?

jkmassel
jkmassel approved these changes Jun 10, 2026
View reviewed changes
Comment thread Modules/Sources/WordPressMediaLibrary/Models/MediaKind.swift
}
}

var systemImageName: String {

@jkmassel jkmassel Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is repeated in MediaGridCell.content – we should probably only have one source of truth for this?

@crazytonyli crazytonyli Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely? I think it's okay to leave a duplicate? This systemImageName is used in a picker row, which is displayed as "[icon] [title]". MediaGridCell.content shows the image or a placeholder image for audio. I think it should be okay if the "placeholder image" in the cell is different from the icon in the picker.

@crazytonyli crazytonyli added this pull request to the merge queue Jun 10, 2026
Merged via the queue into trunk with commit fedb3ce Jun 10, 2026
26 checks passed
@crazytonyli crazytonyli deleted the task/media-v2-grid branch June 10, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkmassel jkmassel jkmassel approved these changes

Assignees

No one assigned

Labels

Media

Projects

None yet

Milestone

27.0

Development

Successfully merging this pull request may close these issues.

4 participants

@crazytonyli @dangermattic @wpmobilebot @jkmassel