Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify xcconfig #24280

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Draft

Simplify xcconfig #24280

wants to merge 3 commits into from

Conversation

kean
Copy link
Contributor

@kean kean commented Mar 21, 2025

Testing builds for Jetpack:

Debug

(lldb) po BuildSettings.current
▿ BuildSettings
  - configuration : BuildSettingsKit.BuildConfiguration.debug
  - brand : BuildSettingsKit.AppBrand.jetpack
  - pushNotificationAppID : "\"com.jetpack.appstore.dev\""
  - appGroupName : "group.org.wordpress"
  - appKeychainAccessGroup : "3TMU3BH3NK.org.wordpress"
  - eventNamePrefix : "jpios"
  - explatPlatform : "wpios"
  - itunesAppID : "1565481562"

Relese

  ▿ BuildSettings
  - configuration : BuildSettingsKit.BuildConfiguration.release
  - brand : BuildSettingsKit.AppBrand.jetpack
  - pushNotificationAppID : "\"com.jetpack.appstore\""
  - appGroupName : "group.org.wordpress"
  - appKeychainAccessGroup : "3TMU3BH3NK.org.wordpress"
  - eventNamePrefix : "jpios"
  - explatPlatform : "wpios"
  - itunesAppID : "1565481562"

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the General label Mar 21, 2025
@kean kean added this to the 25.9 milestone Mar 21, 2025
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@kean kean force-pushed the task/simplify-xcconfig branch from 5c7865a to 4017aa2 Compare March 21, 2025 01:01
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24280-4017aa2
Version25.8
Bundle IDorg.wordpress.alpha
Commit4017aa2
App Center BuildWPiOS - One-Offs #11778
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24280-4017aa2
Version25.8
Bundle IDcom.jetpack.alpha
Commit4017aa2
App Center Buildjetpack-installable-builds #10804
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Comment on lines +1 to +2
// Shared

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: It's sort of implied that these are shared settings given we're in "common".

Suggested change
// Shared

But okay to leave it if you want homogeneous separation headings.

Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far!

Keen to see more settings going into xcconfigs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants