-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify xcconfig #24280
base: trunk
Are you sure you want to change the base?
Simplify xcconfig #24280
Conversation
Generated by 🚫 Danger |
5c7865a
to
4017aa2
Compare
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr24280-4017aa2 | |
Version | 25.8 | |
Bundle ID | org.wordpress.alpha | |
Commit | 4017aa2 | |
App Center Build | WPiOS - One-Offs #11778 |
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr24280-4017aa2 | |
Version | 25.8 | |
Bundle ID | com.jetpack.alpha | |
Commit | 4017aa2 | |
App Center Build | jetpack-installable-builds #10804 |
// Shared | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: It's sort of implied that these are shared settings given we're in "common".
// Shared |
But okay to leave it if you want homogeneous separation headings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far!
Keen to see more settings going into xcconfig
s!
Testing builds for Jetpack:
Debug
Relese
To test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: