Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move BuildConfiguration to BuildSettingsKit #24276

Merged
merged 7 commits into from
Mar 21, 2025
Merged

Conversation

kean
Copy link
Contributor

@kean kean commented Mar 20, 2025

Changes:

  • Move BuildConfiguration (used across multiple targets) to BuildSettingsKit
  • Instead of using separate compiler flag, define build configuration in .plist (.xcconfig)
  • Remove ~= operator – we have only three types and it's rarely used
  • Rename .localDeveloper to .debug to match the actual build configurations in Xcode

To test:

When using Debug build configuration:

(lldb) po BuildConfiguration.current
BuildSettingsKit.BuildConfiguration.debug

Release:

(lldb) po BuildConfiguration.current
BuildSettingsKit.BuildConfiguration.release

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean force-pushed the task/move-build-configuration branch from db6d719 to 9b21731 Compare March 20, 2025 17:05
@dangermattic
Copy link
Collaborator

dangermattic commented Mar 20, 2025

1 Warning
⚠️ This PR is assigned to the milestone 25.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@kean kean added the General label Mar 20, 2025
@kean kean added this to the 25.9 milestone Mar 20, 2025
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 20, 2025

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24276-6d9c36e
Version25.8
Bundle IDorg.wordpress.alpha
Commit6d9c36e
App Center BuildWPiOS - One-Offs #11774
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 20, 2025

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24276-6d9c36e
Version25.8
Bundle IDcom.jetpack.alpha
Commit6d9c36e
App Center Buildjetpack-installable-builds #10800
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@@ -2,3 +2,4 @@

BUILD_SCHEME = Jetpack
WP_PUSH_NOTIFICATION_APP_ID = "com.jetpack.alpha"
WP_BUILD_CONFIGURATION = alpha
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm planning to remove this duplication (WP/JP), but it requires refactoring the .xcconfig file. There has two be only three:

Common <- WordPress
Common  <- Jetpack

@kean kean added this pull request to the merge queue Mar 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Mar 20, 2025
@kean kean enabled auto-merge March 20, 2025 22:35
@kean kean requested a review from mokagio March 20, 2025 22:40
@kean kean added this pull request to the merge queue Mar 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 20, 2025
@kean kean added this pull request to the merge queue Mar 20, 2025
Merged via the queue into trunk with commit 018da55 Mar 21, 2025
25 checks passed
@kean kean deleted the task/move-build-configuration branch March 21, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants