Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup String+Extensions in Share app extension #24264

Merged
merged 3 commits into from
Mar 20, 2025

Conversation

kean
Copy link
Contributor

@kean kean commented Mar 19, 2025

  • Move code shared across targets to WordPressShared
  • Keep the code used only by the extension but remove the membership from other targets

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the General label Mar 19, 2025
@kean kean added this to the 25.9 milestone Mar 19, 2025
@kean kean requested review from crazytonyli and mokagio March 19, 2025 23:19
@kean kean enabled auto-merge March 19, 2025 23:19
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 25.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 20, 2025

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24264-498d3ae
Version25.8
Bundle IDorg.wordpress.alpha
Commit498d3ae
App Center BuildWPiOS - One-Offs #11750
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 20, 2025

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24264-498d3ae
Version25.8
Bundle IDcom.jetpack.alpha
Commit498d3ae
App Center Buildjetpack-installable-builds #10776
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean added this pull request to the merge queue Mar 20, 2025
Merged via the queue into trunk with commit 9b65f8f Mar 20, 2025
25 checks passed
@kean kean deleted the task/cleanup-string-extensions-in-share-extension branch March 20, 2025 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants