Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #24244: Dismiss the 'Delete Site' view controller #24254

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

Fix #24244: Dismiss the 'Delete Site' view controller #24254

wants to merge 4 commits into from
+9 −2

Conversation

crazytonyli
Copy link
Contributor

Note

This PR is built on top of #24243.

Fixes #24244.

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@crazytonyli crazytonyli added this to the 25.9 milestone Mar 19, 2025
@crazytonyli crazytonyli requested review from pmusolino and kean March 19, 2025 09:28
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24254-689ce2a
Version25.8
Bundle IDorg.wordpress.alpha
Commit689ce2a
App Center BuildWPiOS - One-Offs #11728
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24254-689ce2a
Version25.8
Bundle IDcom.jetpack.alpha
Commit689ce2a
App Center Buildjetpack-installable-builds #10756
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Base automatically changed from bugfix/issue-23344 to trunk March 19, 2025 23:14
kean
kean reviewed Mar 20, 2025
View reviewed changes
Copy link
Contributor

@kean kean left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey it looks like it contains changes from #24243. Would you mind updating it please?

The changes look good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kean kean kean left review comments

@pmusolino pmusolino Awaiting requested review from pmusolino

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
iPad Site Management
Projects
None yet
Milestone
25.9
Development

Successfully merging this pull request may close these issues.
3 participants
@crazytonyli @wpmobilebot @kean